Skip to content

bpo-21056: Document return type of next method of csv reader #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 23, 2017
Merged

bpo-21056: Document return type of next method of csv reader #146

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c03618a
bpo-29521 document return type of next method of csv reader
aktech Feb 18, 2017
b2638a0
Explicitly mention the object type reader()/DictReader
aktech Feb 18, 2017
b3699ad
Address comments: use :func: and :class:
aktech Feb 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Doc/library/csv.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,8 +401,9 @@ Reader objects (:class:`DictReader` instances and objects returned by the

.. method:: csvreader.__next__()

Return the next row of the reader's iterable object as a list, parsed according
to the current dialect. Usually you should call this as ``next(reader)``.
Return the next row of the reader's iterable object as a list (if reader) or
dict (if DictReader), parsed according to the current dialect. Usually you
should call this as ``next(reader)``.
Copy link
Contributor

@DimitrisJim DimitrisJim Feb 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to change these to:

Return the next row of the reader's iterable object as a list (if the object was returned from reader()) or a dict (if it is a DictReader) [...]

Copy link
Contributor Author

@aktech aktech Feb 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good! Fixed.



Reader objects have the following public attributes:
Expand Down