gh-143904: Raise OverflowError instead of IndexError for too large offset in struct.pack_into()#143905
Merged
serhiy-storchaka merged 1 commit intopython:mainfrom Feb 1, 2026
Conversation
…rge offset in struct.pack_into()
skirpichev
reviewed
Jan 16, 2026
|
|
||
| buffer: Py_buffer(accept={rwbuffer}) | ||
| offset as offset_obj: object | ||
| offset: Py_ssize_t |
Member
There was a problem hiding this comment.
This long-time behavior, I think we need a deprecation.
Member
Author
There was a problem hiding this comment.
This behavior is uncommon, it was not documented and not covered by tests, it should not occur in normal code. This looks like a long-time bug, we just do not backport its fix.
It is not easy to deprecate a raised exception, and deprecation will have effect comparable with simple changing the exception type. We usually do not do this.
vstinner
approved these changes
Jan 16, 2026
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM. It seems safe and reasonable to raise a different exception for this corner case.
Aniketsy
pushed a commit
to Aniketsy/cpython
that referenced
this pull request
Feb 3, 2026
…rge offset in struct.pack_into() (pythonGH-143905)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.