Skip to content

bpo-37408: Specify that tarfile "format" argument is only for writing #14389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 28, 2019
Merged

bpo-37408: Specify that tarfile "format" argument is only for writing #14389

merged 1 commit into from
Sep 28, 2019

Conversation

pakal
Copy link
Contributor

@pakal pakal commented Jun 26, 2019 •
edited by bedevere-bot
Loading

According to https://bugs.python.org/issue30661#msg339300 , "format" argument of Tarfile.open() only concerns the writing of files. It's worth mentioning it in the doc, if it's True (confirmation from core maintainers is welcome).

https://bugs.python.org/issue37408

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jun 26, 2019
mangrisano
mangrisano approved these changes Jun 26, 2019
View reviewed changes
Copy link
Contributor

@mangrisano mangrisano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pakal
Copy link
Contributor Author

pakal commented Jul 7, 2019

I guess this PR could have a "skip news" tag (I don't seem to be allowed to add it)?

@pakal
Copy link
Contributor Author

pakal commented Sep 20, 2019

Could anyone please add the "skip news" label? And merge it if it's OK? ^^

@merwok merwok changed the title bpo-37408: Precise that Tarfile "format" argument only concerns writing. bpo-37408: Specify that tarfile "format" argument only concerns writing Sep 20, 2019
@merwok merwok changed the title bpo-37408: Specify that tarfile "format" argument only concerns writing bpo-37408: Specify that tarfile "format" argument is only for writing Sep 20, 2019
@gpshead gpshead merged commit c5a7e0c into python:master Sep 28, 2019
@miss-islington
Copy link
Contributor

Thanks @pakal for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @pakal and @gpshead, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker c5a7e0ce194c0eafe82eb3e431881012398e7d46 3.8

@miss-islington
Copy link
Contributor

Thanks @pakal for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-16465 is a backport of this pull request to the 3.8 branch.

ambv pushed a commit that referenced this pull request Sep 30, 2019
@miss-islington @pakal @ambv
bpo-37408: Precise that Tarfile "format" argument only concerns writi…
1aeb720 
…ng. (GH-14389) (#16465)

(cherry picked from commit c5a7e0c)

Co-authored-by: Pascal Chambon <pythoniks@gmail.com>
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@pakal
bpo-37408: Precise that Tarfile "format" argument only concerns writi…
7701bf8 
…ng. (pythonGH-14389)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpshead gpshead gpshead approved these changes

@merwok merwok merwok approved these changes

@mangrisano mangrisano mangrisano approved these changes

Assignees

@gpshead gpshead

Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pakal @miss-islington @bedevere-bot @gpshead @merwok @mangrisano