gh-143181: Fix 'overriden' -> 'overridden' in c-api/module.rst#143182
gh-143181: Fix 'overriden' -> 'overridden' in c-api/module.rst#143182terryjreedy merged 2 commits intopython:mainfrom
Conversation
|
There's some "overriden" in test comments, want to fix them too? Also, no need to create an issue next time for trivial things like typo fixes. https://devguide.python.org/getting-started/pull-request-lifecycle/#id2 |
Need case-sensitive search to no match |
|
Terry, here is a case-insensitive grep: |
a7063df to
8b4c5ef
Compare
|
Changed "overriden" -> "overridden" in the tests. Class names like OverrideNew and OverrideNeither were already spelled correctly with "Override", so they didn't need changing. |
|
My apologies, I meant case-sensitive to avoid fake hits. |
|
Thanks @duane9 for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
|
Sorry, @duane9 and @terryjreedy, I could not cleanly backport this to |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
The doc is not in 3.14. As I noted above, the tests are, but they also are not in 3.13. |
|
I tried the 3.14 cherry_picker fix but I don't understand how to fix the merge conflict here. Might be simpler to start fresh. I'll leave for someone else or we can not backport. Not essential here. |
|
If one were to open a PR that fixes just typos in tests we would generally reject it, I think we should apply the same logic to the backport. |
Doc/c-api/module.rst line 574:
📚 Documentation preview 📚: https://cpython-previews--143182.org.readthedocs.build/