Skip to content

gh-139743: avoid print twice verbose version for sqlite tests#141618

Closed
yihong0618 wants to merge 2 commits intopython:mainfrom
yihong0618:hy/close_issue_139743
Closed

gh-139743: avoid print twice verbose version for sqlite tests#141618
yihong0618 wants to merge 2 commits intopython:mainfrom
yihong0618:hy/close_issue_139743

Conversation

@yihong0618
Copy link
Contributor

@yihong0618 yihong0618 commented Nov 16, 2025

follow #139743
avoid print twice

after this patch

➜  cpython git:(main) ./python.exe -m test test_sqlite3 -v
== CPython 3.15.0a1+ (heads/main:ed73c909f2, Nov 16 2025, 15:29:51) [Clang 17.0.0 (clang-1700.0.13.5)]
== macOS-15.3.2-arm64-arm-64bit-Mach-O little-endian
== Python build: release
== cwd: /Users/yihong/repos/cpython/build/test_python_worker_37275æ
== CPU count: 10
== encodings: locale=UTF-8 FS=utf-8
== resources: all test resources are disabled, use -u option to unskip tests

Using random seed: 643038146
0:00:00 load avg: 1.46 Run 1 test sequentially in a single process
0:00:00 load avg: 1.46 [1/1] test_sqlite3
test_sqlite3: testing with SQLite version 3.43.2
test_bad_source_closed_connection (test.test_sqlite3.test_backup.BackupTests.test_bad_source_closed_connection) ... ok

Signed-off-by: yihong0618 <zouzou0208@gmail.com>
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not work if you run tests as:

./python -m unittest discover -v Lib/test/test_sqlite3/ -t Lib/

Signed-off-by: yihong0618 <zouzou0208@gmail.com>
@yihong0618
Copy link
Contributor Author

This does not work if you run tests as:

./python -m unittest discover -v Lib/test/test_sqlite3/ -t Lib/

use global instead...

Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@aisk aisk added the skip news label Nov 23, 2025
@yihong0618 yihong0618 closed this by deleting the head repository Dec 16, 2025
@yihong0618
Copy link
Contributor Author

oh my god I delete my fork repo by accident ......and all patch gone

@serhiy-storchaka
Copy link
Member

See https://docs.github.com/en/repositories/creating-and-managing-repositories/restoring-a-deleted-repository .

If this does not work, you can perhaps restore it from your local clone.

If this does not work, you can still get raw patch for a PR. Add .patch or diff to the PR URL, e.g. https://patch-diff.githubusercontent.com/raw/python/cpython/pull/141618.patch. Create a new clone of the repository, a new branch on it, import the patch, and create a new PR.

@yihong0618
Copy link
Contributor Author

See https://docs.github.com/en/repositories/creating-and-managing-repositories/restoring-a-deleted-repository .

If this does not work, you can perhaps restore it from your local clone.

If this does not work, you can still get raw patch for a PR. Add .patch or diff to the PR URL, e.g. https://patch-diff.githubusercontent.com/raw/python/cpython/pull/141618.patch. Create a new clone of the repository, a new branch on it, import the patch, and create a new PR.

first one work and save all my branch but...the PR can not restore, I will create a new for this one
sorry for the noise again...

@serhiy-storchaka
Copy link
Member

It seems that your repository was restored, but the PR is still dead. You can create new PRs. Go to the list of branches https://github.com/yihong0618/cpython/branches, click on the branch menu "..." at far right, select "Compare" -- and now you can create a new PR.

Please ping me for reviews.

@yihong0618
Copy link
Contributor Author

It seems that your repository was restored, but the PR is still dead. You can create new PRs. Go to the list of branches https://github.com/yihong0618/cpython/branches, click on the branch menu "..." at far right, select "Compare" -- and now you can create a new PR.

Please ping me for reviews.

Thank you very much will do it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants