gh-132657: Add regression test for PySet_Contains#141411
gh-132657: Add regression test for PySet_Contains#141411kumaraditya303 merged 3 commits intopython:mainfrom
Conversation
As discussed in pythongh-141183, the test suite did not test that PySet_Contains does not convert unhashable key into a frozenset. This commit adds a regression test for this behavior, to ensure that any behavior change is caught by the test suite.
3434a3d to
9d02192
Compare
|
You need to call the function as well no? Check |
Co-authored-by: Kumar Aditya <kumaraditya@python.org>
It's called in |
|
Thanks @Carreau for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
Thanks @Carreau for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
…able type (pythonGH-141411) (cherry picked from commit 2ac738d) Co-authored-by: M Bussonnier <bussonniermatthias@gmail.com>
|
GH-141467 is a backport of this pull request to the 3.13 branch. |
…able type (pythonGH-141411) (cherry picked from commit 2ac738d) Co-authored-by: M Bussonnier <bussonniermatthias@gmail.com>
|
GH-141468 is a backport of this pull request to the 3.14 branch. |
|
Thanks! |
|
|
|
Thanks ! |
As discussed in gh-141183, the test suite did not
test that
PySet_Containsdoes not convert unhashable key into a frozenset.This commit adds a regression test for this
behavior, to ensure that any behavior change is
caught by the test suite.
--
I'm not sure opening a GitHub issue, or having a blurb is necessary as this only adds a test.
Here is the link to the comment where @kumaraditya303 suggested for me to send a test as a separate PR.