[3.13] gh-135307: Fix email error when policy max_line_length is set to 0 or None (GH-135367) #140917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s set to 0 or None (pythonGH-135367) (cherry picked from commit 6d45cd8) Co-authored-by: Jiucheng(Oliver) <git.jiucheng@gmail.com> RDM: Like the change made in a earlier PR to the folder, we can/must use 'maxlen' as a stand in for 'unlimited' when computing line lengths when max_line_length is 0 or None; otherwise the computation results in a traceback.
bitdancer
reviewed
Nov 2, 2025
Lib/test/test_email/test_message.py
Outdated
| parsed_body = parsed.get_body().get_content().rstrip('\n') | ||
| self.assertEqual(parsed_body, body) | ||
|
|
||
| def test_invalid_header_names(self): |
Member
There was a problem hiding this comment.
These invalid header name tests are the conflict that caused the automatic back port to fail. You'll need to delete them (they are tests for a change that was not back ported from 3.14 to 3.13). (cherry-picker conflicts can be quite confusing).
Contributor
Author
There was a problem hiding this comment.
I see, thanks. I am going to address that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 6d45cd8)
RDM: Like the change made in a earlier PR to the folder, we can/must use 'maxlen' as a stand in for 'unlimited' when computing line lengths when max_line_length is 0 or None; otherwise the computation results in a traceback.
email.policy.Policy.max_line_lengthis falsey #135307