-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
bpo-37271: Optimize bytecode multiple times until it cannot be optimized further #14068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@pablogsal Any chance you want to help get #13600 finished? |
@nedbat Sure, I will talk with Victor to see if we can push it forward. |
576034a
to
f9b5588
Compare
64fa0b9
to
8188a1a
Compare
@serhiy-storchaka What do you think about this approach? |
8188a1a
to
282da9e
Compare
9119526
to
68a2657
Compare
I have rebased and address the feedback. Also, I have added a max cap of iterations (although is not needed, it can be proven that the while loop will always finish) to make sure the time expended in the loop is always bounded. |
d9f5d4a
to
99bb01a
Compare
7aed1c2
to
a5ec1be
Compare
Co-Authored-By: Zackery Spytz <zspytz@gmail.com>
f4101a8
to
cba4927
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general, just a couple of questions.
cc7a51f
to
cba4927
Compare
@markshannon I have added some comments as requested, check if they look good to you :) |
4c853b8
to
22560ac
Compare
CC: @Yhg1s |
This is the code that is failing the assert currently:
|
GH-15970 should fix the lnotab issue. |
https://bugs.python.org/issue37271