Skip to content

gh-139922: Tail calling for MSVC (VS 2026) #139962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Fidget-Spinner wants to merge 33 commits into from
Closed

gh-139922: Tail calling for MSVC (VS 2026) #139962

Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
82d1259
Brandt's changes
Fidget-Spinner Aug 21, 2025
3248658
Hulon's and mine changes
Fidget-Spinner Aug 21, 2025
9ac430d
push stackrefs into tstate
Fidget-Spinner Aug 21, 2025
085c1d7
Fix last few remaining problems
Fidget-Spinner Aug 21, 2025
0b12f2e
fix handling of recursion
Fidget-Spinner Aug 24, 2025
acf48f5
Changes by Chris to support clang-cl
Fidget-Spinner Oct 11, 2025
35e96c1
Make the restrict MSVC only for now
Fidget-Spinner Oct 11, 2025
d7737e9
Merge remote-tracking branch 'upstream/main' into msvc-tailcall-take-two
Fidget-Spinner Oct 11, 2025
86f19cf
Change restricts to MSVC only
Fidget-Spinner Oct 11, 2025
40013cc
📜🤖 Added by blurb_it.
blurb-it[bot] Oct 11, 2025
48db59e
Reduce diff
Fidget-Spinner Oct 11, 2025
bc9d23c
Merge branch 'msvc-tailcall-take-two' of github.com:Fidget-Spinner/cp…
Fidget-Spinner Oct 11, 2025
19e02c2
Work around specialization
Fidget-Spinner Oct 11, 2025
66ec774
Fix VS 2026
Fidget-Spinner Oct 11, 2025
50f8ff7
fix a typo
Fidget-Spinner Oct 11, 2025
5d908b4
Move to macros to internal header
Fidget-Spinner Oct 11, 2025
0786133
Merge branch 'msvc-tailcall-take-two' of github.com:Fidget-Spinner/cp…
Fidget-Spinner Oct 11, 2025
e699d40
Reduce number of restricts
Fidget-Spinner Oct 13, 2025
66d6c39
Merge branch 'msvc-tailcall-take-two' of https://github.com/Fidget-Sp…
Fidget-Spinner Oct 13, 2025
5584fec
Reduce restrict use even more, reduce usage
Fidget-Spinner Oct 13, 2025
7eeeaa8
Apply Chris' changes
Fidget-Spinner Oct 23, 2025
6f3d525
Merge remote-tracking branch 'upstream/main' into msvc-tailcall-take-two
Fidget-Spinner Nov 4, 2025
81618e2
Merge remote-tracking branch 'upstream/main' into msvc-tailcall-take-two
Fidget-Spinner Nov 11, 2025
2008d1d
Use choco for now to get VS 2026
Fidget-Spinner Nov 11, 2025
7c84388
Update tail-call.yml
Fidget-Spinner Nov 11, 2025
68b41cf
Update tail-call.yml
Fidget-Spinner Nov 11, 2025
c7316fc
Update tail-call.yml
Fidget-Spinner Nov 11, 2025
9214d5b
Update tail-call.yml
Fidget-Spinner Nov 11, 2025
52c6f9c
Update tail-call.yml
Fidget-Spinner Nov 11, 2025
34d98d3
Update tail-call.yml
Fidget-Spinner Nov 11, 2025
7ec626e
Update tail-call.yml
Fidget-Spinner Nov 11, 2025
ad1c5a2
Update tail-call.yml
Fidget-Spinner Nov 11, 2025
4155337
Update tail-call.yml
Fidget-Spinner Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use choco for now to get VS 2026
  • Loading branch information
@Fidget-Spinner
Fidget-Spinner committed Nov 11, 2025
commit 2008d1da3be7647b49e7f39401bcaef01bcad286
11 changes: 4 additions & 7 deletions .github/workflows/tail-call.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,19 +79,16 @@ jobs:
with:
python-version: '3.11'

- name: Native Windows (debug)
- name: Native Windows MSVC (release)
if: runner.os == 'Windows' && matrix.architecture != 'ARM64'
shell: cmd
run: |
choco install llvm --allow-downgrade --no-progress --version ${{ matrix.llvm }}.1.0
set PlatformToolset=clangcl
set LLVMToolsVersion=${{ matrix.llvm }}.1.0
set LLVMInstallDir=C:\Program Files\LLVM
call ./PCbuild/build.bat --tail-call-interp -d -p ${{ matrix.architecture }}
choco install visualstudio2026buildtools-preview --pre
call ./PCbuild/build.bat --tail-call-interp -p ${{ matrix.architecture }} "/p:PlatformToolset=v145"
call ./PCbuild/rt.bat -d -p ${{ matrix.architecture }} -q --multiprocess 0 --timeout 4500 --verbose2 --verbose3

# No tests (yet):
- name: Emulated Windows (release)
- name: Emulated Windows Clang (release)
if: runner.os == 'Windows' && matrix.architecture == 'ARM64'
shell: cmd
run: |
Expand Down
Loading