gh-139262: Prevent swallowing REPL input on Windows#139263
Merged
ambv merged 3 commits intopython:mainfrom Jan 2, 2026
Merged
Conversation
chris-eibl
commented
Sep 23, 2025
| return False | ||
| return True | ||
|
|
||
| def wait(self, timeout: float | None) -> bool: |
Member
Author
There was a problem hiding this comment.
The fix is easy and brings us in sync with unix_console.py
cpython/Lib/_pyrepl/unix_console.py
Lines 434 to 441 in 6b4e3fe
Member
Author
|
macOS test_ssl failure for sure unrelated :) |
|
Thanks @chris-eibl for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 2, 2026
Contributor
|
Thanks for your fix, Chris. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 2, 2026
|
GH-143362 is a backport of this pull request to the 3.14 branch. |
|
GH-143363 is a backport of this pull request to the 3.13 branch. |
ambv
added a commit
that referenced
this pull request
Jan 2, 2026
ambv
added a commit
that referenced
this pull request
Jan 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Especially when using the meta (ALT) key.
For instance, Alt + b for
cpython/Lib/_pyrepl/reader.py
Line 85 in 6b4e3fe
the first hit is swallowed in a Windwos Terminal.
It happens, when there is nothing to be read from the console, i.e.
cpython/Lib/_pyrepl/windows_console.py
Line 569 in 6b4e3fe
returns
Falsebut there is data inself.event_queue.