gh-129813, PEP 782: Use PyBytesWriter in _io.FileIO.readall#138901
Merged
vstinner merged 3 commits intopython:mainfrom Sep 15, 2025
Merged
gh-129813, PEP 782: Use PyBytesWriter in _io.FileIO.readall#138901vstinner merged 3 commits intopython:mainfrom
vstinner merged 3 commits intopython:mainfrom
Conversation
Performance about the same, using the benchmark from pythongh-120754: ``` pyperf compare_to main.json pep782.json read_file_small: Mean +- std dev: [main] 5.71 us +- 0.05 us -> [pep782] 5.68 us +- 0.05 us: 1.01x faster read_file_large: Mean +- std dev: [main] 89.7 us +- 0.9 us -> [pep782] 86.9 us +- 0.8 us: 1.03x faster read_all_rst_bytes: Mean +- std dev: [main] 926 us +- 8 us -> [pep782] 920 us +- 12 us: 1.01x faster read_all_rst_text: Mean +- std dev: [main] 2.24 ms +- 0.02 ms -> [pep782] 2.17 ms +- 0.04 ms: 1.03x faster Benchmark hidden because not significant (1): read_all_py_bytes Geometric mean: 1.01x faster ```
vstinner
reviewed
Sep 15, 2025
Misc/NEWS.d/next/Library/2025-09-14-18-21-17.gh-issue-129813.XN7EyU.rst
Outdated
Show resolved
Hide resolved
vstinner
approved these changes
Sep 15, 2025
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM, but I suggest removing the NEWS entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Performance largely flat, maybe faster on
bm_readall.pyfrom gh-120754 (read all python docs and py files using readall).