Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-37177: make IDLE's search dialogs transient #13869

Merged
merged 3 commits into from
Jun 7, 2019
Merged

bpo-37177: make IDLE's search dialogs transient #13869

merged 3 commits into from
Jun 7, 2019

Conversation

taleinat
Copy link
Contributor

@taleinat taleinat commented Jun 6, 2019 •
edited by bedevere-bot
Loading

@taleinat taleinat added type-bug An unexpected behavior, bug, or error needs backport to 2.7 skip news labels Jun 6, 2019
@taleinat taleinat requested a review from terryjreedy June 6, 2019 16:26
@taleinat taleinat self-assigned this Jun 6, 2019
@taleinat
Copy link
Contributor Author

taleinat commented Jun 6, 2019

@IrvKalb, your review would be appreciated!

@terryjreedy
Copy link
Member

terryjreedy commented Jun 6, 2019 •
edited by bedevere-bot
Loading

Even if this does not fix all hiding issues, it should be merged, with a blurb added, as a fix for bpo-24139.
Possible text: "Properly 'attach' search dialogs to their edit windows so that they work like other dialogs and do not get hidden beneath."

@taleinat
Copy link
Contributor Author

taleinat commented Jun 6, 2019 •
edited by bedevere-bot
Loading

as a fix for bpo-24139

That appears to be the wrong issue.

@taleinat taleinat removed the skip news label Jun 6, 2019
@terryjreedy
Copy link
Member

terryjreedy commented Jun 7, 2019 •
edited by bedevere-bot
Loading

Sorry, bpo-24039.

@taleinat taleinat merged commit 554450f into python:master Jun 7, 2019
@miss-islington
Copy link
Contributor

Thanks @taleinat for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.7, 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-13878 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 7, 2019
@taleinat @miss-islington
bpo-37177: make IDLE's search dialogs transient (pythonGH-13869)
fd5d470 
This avoids the search dialogs being hidden behind the editor window.
(cherry picked from commit 554450f)

Co-authored-by: Tal Einat <taleinat@gmail.com>
@bedevere-bot
Copy link

GH-13879 is a backport of this pull request to the 3.7 branch.

@miss-islington
Copy link
Contributor

Sorry, @taleinat, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 554450fb4e95066e825bdb4a2d544a490daeebdc 2.7

taleinat added a commit to taleinat/cpython that referenced this pull request Jun 7, 2019
@taleinat
[2.7] bpo-37177: make IDLE's search dialogs transient (pythonGH-13869)
ac79c93 
This avoids the search dialogs being hidden behind the editor window..
(cherry picked from commit 554450f)

Co-authored-by: Tal Einat <taleinat@gmail.com>
@bedevere-bot
Copy link

GH-13880 is a backport of this pull request to the 2.7 branch.

miss-islington added a commit that referenced this pull request Jun 7, 2019
@miss-islington @taleinat
bpo-37177: make IDLE's search dialogs transient (GH-13869)
295fe32 
This avoids the search dialogs being hidden behind the editor window.
(cherry picked from commit 554450f)

Co-authored-by: Tal Einat <taleinat@gmail.com>
@taleinat taleinat deleted the bpo-37177/idle-transient-search-dialogs branch June 7, 2019 06:17
miss-islington added a commit that referenced this pull request Jun 7, 2019
@miss-islington @taleinat
bpo-37177: make IDLE's search dialogs transient (GH-13869)
685b806 
This avoids the search dialogs being hidden behind the editor window.
(cherry picked from commit 554450f)

Co-authored-by: Tal Einat <taleinat@gmail.com>
taleinat added a commit that referenced this pull request Jun 7, 2019
@taleinat
[2.7] bpo-37177: make IDLE's search dialogs transient (GH-13869)
1b57ab5 
This avoids the search dialogs being hidden behind the editor window.

(cherry picked from commit 554450f)
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@taleinat @DinoV
bpo-37177: make IDLE's search dialogs transient (pythonGH-13869)
2d6fdd7 
This avoids the search dialogs being hidden behind the editor window.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terryjreedy terryjreedy Awaiting requested review from terryjreedy

Assignees

@taleinat taleinat

Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@taleinat @terryjreedy @miss-islington @bedevere-bot @the-knights-who-say-ni