gh-128042: configure complains when CFLAGS=-O0 and --enable-optimizations
#137975
Conversation
…ptimizations are set
taegyunkim
requested review from
erlend-aasland,
corona10 and
AA-Turner
as code owners
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
| # Check for conflicting CFLAGS=-O0 and --enable-optimizations | ||
| case "$CFLAGS" in | ||
| *-O0*) | ||
| AC_MSG_ERROR([CFLAGS contains -O0 which conflicts with --enable-optimizations. Please remove -O0 from CFLAGS or do not use --enable-optimizations.]) |
There was a problem hiding this comment.
Error is too harsh here. Per @hauntsaninja on the devguide, there are lots of combinations of configurations that might not make sense.
I'm also not entirely convinced by the motivation in the issue, as when you are passing explicit CFLAGS and configure options we tend to assume you know what you're doing.
At the very least I would downgrade to an informational note or warning, if we do change something here.
A
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Uh oh!
There was an error while loading. Please reload this page.