gh-137928: Centralize size validation in multiprocessing.heap #137929
+11
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gh-137928: Refactor to centralize size validation in multiprocessing.heap
Summary
This PR refactors the
multiprocessing.heap
module by centralizing size validation into a private static method (Heap._validate_size
).Previously, the same validation logic was duplicated in both
Heap.malloc()
andBufferWrapper.__init__()
.Changes
Heap._validate_size(size, _maxsize=sys.maxsize)
.malloc()
andBufferWrapper.__init__()
to use this method.sys.maxsize
at definition time to avoid repeated global lookups.Impact