bpo-37146: disable opcache when Py_DEBUG is defined #13787
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--with-pydebug is commonly used to find memory leaks. But opcache makes it harder. So disable opcache when Py_DEBUG is defined.
|
Check out https://github.com/python/cpython/pull/13789/files for a possible more complete fix |
vstinner
approved these changes
Jun 3, 2019
There was a problem hiding this comment.
LGTM. That's a reasonable workaround for https://bugs.python.org/issue37146 for beta1. We can design a better solution after beta1.
pablogsal
approved these changes
Jun 3, 2019
|
@methane: Thanks. I merged your PR to make Refleak buildbots green again (I hope!). |
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
--with-pydebug is commonly used to find memory leaks. But opcache makes it harder. So disable opcache when Py_DEBUG is defined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--with-pydebug is commonly used to find memory leaks.
But opcache makes it harder.
So disable opcache when Py_DEBUG is defined.
https://bugs.python.org/issue37146