Skip to content

gh-137412: fix default_builtin_hashes values in test_hashlib.py#137413

Merged
orsenthil merged 1 commit intopython:mainfrom
picnixz:fix/test/fix-default-builtin-hashes-137412
Aug 7, 2025
Merged

gh-137412: fix default_builtin_hashes values in test_hashlib.py#137413
orsenthil merged 1 commit intopython:mainfrom
picnixz:fix/test/fix-default-builtin-hashes-137412

Conversation

@picnixz
Copy link
Member

@picnixz picnixz commented Aug 5, 2025 •
edited by bedevere-app bot
Loading

@picnixz picnixz requested review from gpshead and tiran as code owners August 5, 2025 10:28
@bedevere-app bedevere-app bot added awaiting core review tests Tests in the Lib/test dir labels Aug 5, 2025
@bedevere-app bedevere-app bot mentioned this pull request Aug 5, 2025
Closed
@picnixz picnixz added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Aug 5, 2025
@picnixz
Copy link
Member Author

picnixz commented Aug 5, 2025

!buildbot FIPS

@bedevere-bot
Copy link

bedevere-bot commented Aug 5, 2025

🤖 New build scheduled with the buildbot fleet by @picnixz for commit 3c05958 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F137413%2Fmerge

The command will test the builders whose names match following regular expression: FIPS

The builders matched are:

  • AMD64 CentOS9 FIPS No Builtin Hashes PR
  • AMD64 RHEL8 FIPS Only Blake2 Builtin Hash PR
  • AMD64 RHEL8 FIPS No Builtin Hashes PR
  • AMD64 CentOS9 FIPS Only Blake2 Builtin Hash PR

picnixz
picnixz commented Aug 5, 2025
View reviewed changes
@picnixz
Copy link
Member Author

picnixz commented Aug 5, 2025

Yeah, failures are fine.

@orsenthil
Copy link
Member

orsenthil commented Aug 7, 2025

The errors in the buildbot failures were due to.

ValueError: unsupported hash algorithm blake2b
ValueError: unsupported hash algorithm blake2s

which were successful in the fips build PR.

Just for the cleanliness, it might be a good idea to to ignore these tests in the FIPS No Builtin Hashes workers - in a separate change.

The changes in this PR looks good to me.

@orsenthil orsenthil merged commit deb385a into python:main Aug 7, 2025
87 of 91 checks passed
@miss-islington-app
Copy link

miss-islington-app bot commented Aug 7, 2025

Thanks @picnixz for the PR, and @orsenthil for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 7, 2025
@picnixz @miss-islington
pythongh-137412: fix default_builtin_hashes values in `test_hashlib…
660837f 
….py` (pythonGH-137413)

fix `default_builtin_hashes` in test_hashlib
(cherry picked from commit deb385a)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 7, 2025
@picnixz @miss-islington
pythongh-137412: fix default_builtin_hashes values in `test_hashlib…
4817ed6 
….py` (pythonGH-137413)

fix `default_builtin_hashes` in test_hashlib
(cherry picked from commit deb385a)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Aug 7, 2025

GH-137534 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Aug 7, 2025
@bedevere-app
Copy link

bedevere-app bot commented Aug 7, 2025

GH-137535 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Aug 7, 2025
orsenthil pushed a commit that referenced this pull request Aug 7, 2025
@miss-islington @picnixz
[3.13] gh-137412: fix default_builtin_hashes values in `test_hashli…
4ad3603 
…b.py` (GH-137413) (#137535)

gh-137412: fix `default_builtin_hashes` values in `test_hashlib.py` (GH-137413)

fix `default_builtin_hashes` in test_hashlib
(cherry picked from commit deb385a)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@picnixz
Copy link
Member Author

picnixz commented Aug 8, 2025

Yes, the other failures are unrelated and were here for a while. I actually asked the FIPS bots and not FIPS only, which is why I ended up with those failures

@picnixz picnixz deleted the fix/test/fix-default-builtin-hashes-137412 branch August 8, 2025 12:03
hugovk pushed a commit that referenced this pull request Aug 8, 2025
@miss-islington @picnixz
[3.14] gh-137412: fix default_builtin_hashes values in `test_hashli…
f1248cf 
…b.py` (GH-137413) (#137534)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@picnixz @Agent-Hellboy
pythongh-137412: fix default_builtin_hashes values in `test_hashlib…
291b8d6 
….py` (python#137413)

fix `default_builtin_hashes` in test_hashlib
kumaraditya303 pushed a commit to miss-islington/cpython that referenced this pull request Sep 9, 2025
@miss-islington @picnixz @kumaraditya303
[3.14] pythongh-137412: fix default_builtin_hashes values in `test_…
b61d59c 
…hashlib.py` (pythonGH-137413) (python#137534)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@orsenthil orsenthil orsenthil approved these changes

@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner

@tiran tiran Awaiting requested review from tiran

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@picnixz @bedevere-bot @orsenthil