bpo-30224: remove outdated checks in struct #1374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zhangyangyu, thanks for your PR! By analyzing the history of the files in this pull request, we identified @mdickinson, @serhiy-storchaka and @Yhg1s to be potential reviewers. |
| @@ -1390,8 +1360,6 @@ prepare_s(PyStructObject *self) | |||
| num = c - '0'; | |||
| while ('0' <= (c = *s++) && c <= '9') | |||
| num = num*10 + (c - '0'); | |||
| if (c == '\0') | |||
There was a problem hiding this comment.
IMHO, this part is another round same as the previous round but without checks. So c == '\0' can't be true anyway otherwise the previous round should have failed. Even if it could be true, does simply break the loop a right behaviour?
| @@ -1500,7 +1468,7 @@ s_dealloc(PyStructObject *s) | |||
| if (s->s_codes != NULL) { | |||
| PyMem_FREE(s->s_codes); | |||
| } | |||
| Py_XDECREF(s->s_format); | |||
| Py_DECREF(s->s_format); | |||
There was a problem hiding this comment.
There is also Py_XSETREF in Struct___init___impl.
mdickinson
reviewed
May 2, 2017
| @@ -1390,8 +1360,6 @@ prepare_s(PyStructObject *self) | |||
| num = c - '0'; | |||
| while ('0' <= (c = *s++) && c <= '9') | |||
| num = num*10 + (c - '0'); | |||
| if (c == '\0') | |||
There was a problem hiding this comment.
Are you sure that there's no behaviour change here?
serhiy-storchaka
approved these changes
May 2, 2017
|
What's your opinion @mdickinson ? Does it look good to you now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.