gh-135621: Remove dependency on curses from PyREPL by ambv · Pull Request #136758 · python/cpython

ambv · 2025-07-18T14:53:39Z

Issue: Misleading pyrepl warnings when _curses module is missing #135621

ambv · 2025-07-18T22:43:40Z

!buildbot

bedevere-bot · 2025-07-18T22:44:24Z

🤖 New build scheduled with the buildbot fleet by @ambv for commit 58d3e84 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136758%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

ambv · 2025-07-19T08:52:37Z

!buildbot iOS

bedevere-bot · 2025-07-19T08:52:40Z

🤖 New build scheduled with the buildbot fleet by @ambv for commit 0448edd 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136758%2Fmerge

The command will test the builders whose names match following regular expression: iOS

The builders matched are:

iOS ARM64 Simulator PR

ambv · 2025-07-19T08:52:59Z

!buildbot aarch64 Android

bedevere-bot · 2025-07-19T08:53:03Z

🤖 New build scheduled with the buildbot fleet by @ambv for commit 0448edd 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136758%2Fmerge

The command will test the builders whose names match following regular expression: aarch64 Android

The builders matched are:

aarch64 Android PR

encukou

Quick comments (we had a chat in person):

Lib/_pyrepl/terminfo.py

bedevere-bot · 2025-07-19T13:58:14Z

🤖 New build scheduled with the buildbot fleet by @ambv for commit 2a053c5 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136758%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

bedevere-bot · 2025-07-20T10:49:47Z

🤖 New build scheduled with the buildbot fleet by @ambv for commit d080941 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136758%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

miss-islington-app · 2025-07-21T09:57:37Z

Thanks @ambv for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

…6758) (cherry picked from commit 09dfb50) Co-authored-by: Łukasz Langa <lukasz@langa.pl>

bedevere-app · 2025-07-21T09:57:50Z

GH-136915 is a backport of this pull request to the 3.14 branch.

…GH-136915) (cherry picked from commit 09dfb50) Co-authored-by: Łukasz Langa <lukasz@langa.pl>

…6758)

…onGH-136758) (pythonGH-136915) (cherry picked from commit 09dfb50) Co-authored-by: Łukasz Langa <lukasz@langa.pl>

… docs The curses module dependency was removed for the new REPL in pythonGH-136758, so the documentation should no longer mention it as a requirement.

pythongh-135621: Remove dependency on curses from PyREPL

0d2ae7c

ambv requested a review from encukou July 18, 2025 14:53

ambv requested review from lysnikolaou and pablogsal as code owners July 18, 2025 14:53

bedevere-app bot added the awaiting core review label Jul 18, 2025

bedevere-app bot mentioned this pull request Jul 18, 2025

Misleading pyrepl warnings when _curses module is missing #135621

Closed

ambv added 4 commits July 18, 2025 17:15

Add blurb, reformat, fix a type error

6408df6

Fix optional capability handling

8aee463

Skip if termios unavailable

4b70767

Initialize test UnixConsole to xterm

58d3e84

ambv added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 18, 2025

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 18, 2025

Properly gate tests requiring subprocesses

0448edd

encukou reviewed Jul 19, 2025

View reviewed changes

Lib/_pyrepl/terminfo.py Outdated Show resolved Hide resolved

Lib/_pyrepl/terminfo.py Show resolved Hide resolved

Lib/_pyrepl/terminfo.py Outdated Show resolved Hide resolved

Lib/_pyrepl/terminfo.py Show resolved Hide resolved

Lib/_pyrepl/terminfo.py Show resolved Hide resolved

ambv added 5 commits July 19, 2025 13:32

Fix the fix

2a8ea76

Use implicit numbering in _STRING_NAMES

52d1a19

Parse the terminfo file header in one go

7aa2ec8

Make terminal name validation more comprehensive

9db38c7

Scan all paths suggested by capconvert

2a053c5

ambv added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 19, 2025

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 19, 2025

Don't run curses compatibility tests when terminfo not present

d080941

ambv force-pushed the gh-135621 branch from 3742586 to d080941 Compare July 20, 2025 10:49

python deleted a comment from python-cla-bot bot Jul 20, 2025

ambv added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 20, 2025

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 20, 2025

ambv added the needs backport to 3.14 bugs and security fixes label Jul 20, 2025

pablogsal approved these changes Jul 20, 2025

View reviewed changes

bedevere-app bot added awaiting merge and removed awaiting core review labels Jul 20, 2025

ambv merged commit 09dfb50 into python:main Jul 21, 2025
136 checks passed

bedevere-app bot removed the awaiting merge label Jul 21, 2025

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 21, 2025

pythongh-135621: Remove dependency on curses from PyREPL (pythonGH-13…

aa91b6f

…6758) (cherry picked from commit 09dfb50) Co-authored-by: Łukasz Langa <lukasz@langa.pl>

bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jul 21, 2025

ambv added the sprint label Jul 21, 2025

encukou mentioned this pull request Jul 21, 2025

Simplify TermInfo ambv/cpython#102

Closed

ambv added a commit that referenced this pull request Jul 21, 2025

[3.14] gh-135621: Remove dependency on curses from PyREPL (GH-136758) (…

031645a

…GH-136915) (cherry picked from commit 09dfb50) Co-authored-by: Łukasz Langa <lukasz@langa.pl>

ambv deleted the gh-135621 branch July 21, 2025 11:10

taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025

pythongh-135621: Remove dependency on curses from PyREPL (pythonGH-13…

a94c44f

…6758)

Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025

pythongh-135621: Remove dependency on curses from PyREPL (pythonGH-13…

57332f3

…6758)

This was referenced Sep 11, 2025

pyrepl tests on Windows aren't executed anymore #138801

Closed

gh-138801: pyrepl tests on Windows aren't executed anymore #138802

Merged

johnslavik mentioned this pull request Dec 21, 2025

Don't mention curses in the "Interactive Mode" docs #143048

Closed

sandole mentioned this pull request Dec 29, 2025

gh-143048: Remove outdated curses reference in interactive mode docs #143264

Closed

Uh oh!

Conversation

ambv commented Jul 18, 2025 • edited by bedevere-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ambv commented Jul 18, 2025

Uh oh!

bedevere-bot commented Jul 18, 2025

Uh oh!

ambv commented Jul 19, 2025

Uh oh!

bedevere-bot commented Jul 19, 2025

Uh oh!

ambv commented Jul 19, 2025

Uh oh!

bedevere-bot commented Jul 19, 2025

Uh oh!

encukou left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bedevere-bot commented Jul 19, 2025

Uh oh!

bedevere-bot commented Jul 20, 2025

Uh oh!

Uh oh!

miss-islington-app bot commented Jul 21, 2025

Uh oh!

bedevere-app bot commented Jul 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ambv commented Jul 18, 2025 •

edited by bedevere-app bot

Loading