Skip to content

gh-136289: Fix test_sqlite3 on platforms with strict UTF-8 filesystem #136326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 7, 2025
Merged

gh-136289: Fix test_sqlite3 on platforms with strict UTF-8 filesystem #136326

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae12a82
gh-136289: Fix test_sqlite3 on platforms with strict UTF-8 filesystem
serhiy-storchaka Jul 5, 2025
c072d79
Merge branch 'main' into test_sqlite3-undecodable
larryhastings Jul 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 14 additions & 12 deletions Lib/test/test_sqlite3/test_dbapi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@
import warnings

from test.support import (
SHORT_TIMEOUT, check_disallow_instantiation, requires_subprocess,
is_apple, is_emscripten, is_wasi
SHORT_TIMEOUT, check_disallow_instantiation, requires_subprocess
)
from test.support import gc_collect
from test.support import threading_helper, import_helper
Expand Down Expand Up @@ -641,14 +640,21 @@ def test_open_with_path_like_object(self):
self.assertTrue(os.path.exists(path))
cx.execute(self._sql)

def get_undecodable_path(self):
path = TESTFN_UNDECODABLE
if not path:
self.skipTest("only works if there are undecodable paths")
try:
open(path, 'wb').close()
except OSError:
self.skipTest(f"can't create file with undecodable path {path!r}")
unlink(path)
return path

@unittest.skipIf(sys.platform == "win32", "skipped on Windows")
@unittest.skipIf(is_apple, "skipped on Apple platforms")
@unittest.skipIf(is_emscripten or is_wasi, "not supported on Emscripten/WASI")
@unittest.skipUnless(TESTFN_UNDECODABLE, "only works if there are undecodable paths")
def test_open_with_undecodable_path(self):
path = TESTFN_UNDECODABLE
path = self.get_undecodable_path()
self.addCleanup(unlink, path)
self.assertFalse(os.path.exists(path))
with contextlib.closing(sqlite.connect(path)) as cx:
self.assertTrue(os.path.exists(path))
cx.execute(self._sql)
Expand Down Expand Up @@ -688,14 +694,10 @@ def test_open_uri_readonly(self):
cx.execute(self._sql)

@unittest.skipIf(sys.platform == "win32", "skipped on Windows")
@unittest.skipIf(is_apple, "skipped on Apple platforms")
@unittest.skipIf(is_emscripten or is_wasi, "not supported on Emscripten/WASI")
@unittest.skipUnless(TESTFN_UNDECODABLE, "only works if there are undecodable paths")
def test_open_undecodable_uri(self):
path = TESTFN_UNDECODABLE
path = self.get_undecodable_path()
self.addCleanup(unlink, path)
uri = "file:" + urllib.parse.quote(path)
self.assertFalse(os.path.exists(path))
with contextlib.closing(sqlite.connect(uri, uri=True)) as cx:
self.assertTrue(os.path.exists(path))
cx.execute(self._sql)
Expand Down
Loading