gh-135878: Fix crash in types.SimpleNamespace.__repr__#135889
Merged
sobolevn merged 4 commits intopython:mainfrom Jun 24, 2025
Merged
gh-135878: Fix crash in types.SimpleNamespace.__repr__#135889sobolevn merged 4 commits intopython:mainfrom
types.SimpleNamespace.__repr__#135889sobolevn merged 4 commits intopython:mainfrom
Conversation
ZeroIntensity
approved these changes
Jun 24, 2025
Member
ZeroIntensity
left a comment
ZeroIntensity
left a comment
There was a problem hiding this comment.
LGTM. If it's too difficult to come up with a test for this (that isn't the messy fuzzer repro in the issue), I think it's fine to land this without one.
Misc/NEWS.d/next/Library/2025-06-24-14-43-24.gh-issue-135878.Db4roX.rst
Outdated
Show resolved
Hide resolved
…b4roX.rst Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
vstinner
reviewed
Jun 24, 2025
Member
Author
|
Thanks for the good suggestions! |
kumaraditya303
approved these changes
Jun 24, 2025
sobolevn
added
awaiting merge
needs backport to 3.13
|
Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 24, 2025
…nGH-135889) (cherry picked from commit b3ab94a) Co-authored-by: sobolevn <mail@sobolevn.me> Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
|
GH-135895 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 24, 2025
…nGH-135889) (cherry picked from commit b3ab94a) Co-authored-by: sobolevn <mail@sobolevn.me> Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
|
GH-135896 is a backport of this pull request to the 3.14 branch. |
sobolevn
added a commit
that referenced
this pull request
Jun 24, 2025
sobolevn
added a commit
that referenced
this pull request
Jun 24, 2025
AndPuQing
pushed a commit
to AndPuQing/cpython
that referenced
this pull request
Jul 11, 2025
…n#135889) Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Pranjal095
pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
…n#135889) Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
…n#135889) Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Agent-Hellboy
pushed a commit
to Agent-Hellboy/cpython
that referenced
this pull request
Aug 19, 2025
…n#135889) Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note, that there's a small behavior change. We now treat missing keys as errors, because it is the correct thing to do. When
->ns_dictdoes not have keys from itsPyObject_GetIter(keys)- this is strange.Any suggestions about the test case here are welcome!
repr(SimpleNamespace)withtyping.Unionattributes in threads on a free-threading build #135878