gh-135755: rename undocumented HACL_CAN_COMPILE_SIMD{128,256} macros#135847
Conversation
picnixz
requested review from
corona10,
erlend-aasland,
gpshead and
tiran
as code owners
|
!buildbot FIPS only |
|
🤖 New build scheduled with the buildbot fleet by @picnixz for commit bc635b0 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135847%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
encukou
left a comment
encukou
left a comment
There was a problem hiding this comment.
I think they should be backported.
Betas can still have even “significant changes to new features”; renaming macros should be fine.
|
I will actually run the full build bots fleet just to be sure that we won't cause configure & build failures. There will be failures on some build bots (those without BLAKE-2 will fail because of some tests that expect blake2 to exist but that's been failing for the past year). |
picnixz
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @picnixz for commit bc635b0 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135847%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
|
@zanieb Can you check if this PR breaks something on your side? I don't have access to macOS builds and I think you have different configurations that have once caught issues that I didn't know about. TiA |
|
Taking a look, trying to add 3.15 compatibility to python-build-standalone briefly so I can test without backporting. |
|
This seemed to work without issue, though I can only run it locally not across our whole matrix. |
|
Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
|
Sorry, @picnixz, I could not cleanly backport this to |
|
Today, I should be called a conflict solver. |
…8,256}` macros (pythonGH-135847) Rename undocumented `HACL_CAN_COMPILE_SIMD{128,256}` macros to `_Py_HACL_CAN_COMPILE_VEC{128,256}`. These macros are private. (cherry picked from commit 1e975ae) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
|
GH-136045 is a backport of this pull request to the 3.14 branch. |
… macros (python#135847) Rename undocumented `HACL_CAN_COMPILE_SIMD{128,256}` macros to `_Py_HACL_CAN_COMPILE_VEC{128,256}`. These macros are private.
… macros (python#135847) Rename undocumented `HACL_CAN_COMPILE_SIMD{128,256}` macros to `_Py_HACL_CAN_COMPILE_VEC{128,256}`. These macros are private.
… macros (python#135847) Rename undocumented `HACL_CAN_COMPILE_SIMD{128,256}` macros to `_Py_HACL_CAN_COMPILE_VEC{128,256}`. These macros are private.
… macros (python#135847) Rename undocumented `HACL_CAN_COMPILE_SIMD{128,256}` macros to `_Py_HACL_CAN_COMPILE_VEC{128,256}`. These macros are private.
4 participants
@encukou Should this actually be backported? also could you have a look at the renames yourself because I may have misrenamed them (and it's hard to spot typos in one's own code in general), TiA!