Skip to content

bpo-37053: handle strings like u"bar" correctly in Tools/parser/unparse.py #13583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miss-islington merged 3 commits into from
May 26, 2019
Merged

bpo-37053: handle strings like u"bar" correctly in Tools/parser/unparse.py #13583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
889683e
bpo-37053: handle strings like u"bar" correctly in Tools/parser/unpar…
yan12125 May 26, 2019
913265e
📜🤖 Added by blurb_it.
blurb-it[bot] May 26, 2019
64666db
Move the news file to the correct path
yan12125 May 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Lib/test/test_tools/test_unparse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,11 @@ def test_fstrings(self):
self.check_roundtrip(r"""f'{f"{0}"*3}'""")
self.check_roundtrip(r"""f'{f"{y}"*3}'""")

def test_strings(self):
self.check_roundtrip("u'foo'")
self.check_roundtrip("r'foo'")
self.check_roundtrip("b'foo'")

def test_del_statement(self):
self.check_roundtrip("del x, y, z")

Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Tools-Demos/2019-05-26-16-47-06.bpo-37053.-EYRuz.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Handle strings like u"bar" correctly in Tools/parser/unparse.py. Patch by Chih-Hsuan Yen.
2 changes: 2 additions & 0 deletions Tools/parser/unparse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,6 +399,8 @@ def _Constant(self, t):
elif value is ...:
self.write("...")
else:
if t.kind == "u":
self.write("u")
self._write_constant(t.value)

def _List(self, t):
Expand Down