gh-135815: skip netrc security checks if os.getuid is missing#135816
gh-135815: skip netrc security checks if os.getuid is missing#135816picnixz merged 2 commits intopython:mainfrom
netrc security checks if os.getuid is missing#135816Conversation
c472cc9 to
d2a13f6
Compare
serhiy-storchaka
left a comment
There was a problem hiding this comment.
LGTM.
Added a couple of suggestions, it is up to you.
| (f"~/.netrc file owner ({fowner}, {user}) does not match" | ||
| " current user")) |
There was a problem hiding this comment.
The message looks weird. Would not be better to rewrite in in the following way?
(f"~/.netrc file owner ({fowner}) does not match"
f" current user ({user})"))There was a problem hiding this comment.
I'll change it in a follow-up PR so that only unstable branches are affected.
|
Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
…ng (pythonGH-135816) (cherry picked from commit b57b619) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
|
GH-135825 is a backport of this pull request to the 3.14 branch. |
…ng (pythonGH-135816) (cherry picked from commit b57b619) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
|
GH-135826 is a backport of this pull request to the 3.13 branch. |
|
Before python#135816 it was skipped because pwd is missing on Emscripten. Now it isn't skipped because the test no longer requires pwd but it still doesn't work on Emscripten.
netrcsecurity check may fail on WASI due to the lack ofos.getuid#135815