Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create SECURITY.rst #13564

Closed
wants to merge 1 commit into from
Closed

Create SECURITY.rst #13564

wants to merge 1 commit into from

Conversation

vanillajonathan
Copy link

This file is used by GitHub in the security tab.
https://github.com/python/cpython/security/policy

This file is used by GitHub in the security tab.
https://github.com/python/cpython/security/policy
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@asvetlov
Copy link
Contributor

The PR duplicates #13526 I guess

@asvetlov
Copy link
Contributor

Thank you for your contribution.
Sorry, #13526 has merged.
Closing this PR as duplicated.

@asvetlov asvetlov closed this May 25, 2019
+---------+-----------+
| Version | Supported |
+=========+===========+
| 3.7 | Yes |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vanillajonathan FTR, a lot of projects maintain their own pages with docs so the best thing to do is to redirect people there instead of forcing maintainers to watch out for multiple places to update...

btw, are you sure that RST works for this specific file? I wasn't able to locate this in docs

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, reStructuredText works for the security file on GitHub.
Example: https://github.com/apache/airflow/security/policy

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it is a shared part of both Markdown and ReST syntax.
The link to devguide page is preferred anyway for sake of keeping Python versions status information in the single place.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Andrew, I think it's a good idea to keep all files with one extension for the sake of consistency

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't care.
Ok with committed code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review docs Documentation in the Doc dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants