gh-135532: module-wide cleanup for HACL*-based extension modules #135536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!buildbot FIPS only |
|
🤖 New build scheduled with the buildbot fleet by @picnixz for commit abfa1af 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135536%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
…135239 # Conflicts: # Modules/_hashopenssl.c # Modules/blake2module.c
…135239 # Conflicts: # Modules/hmacmodule.c
…135239 # Conflicts: # Modules/hmacmodule.c
…135239 # Conflicts: # Modules/md5module.c
|
Waiting for other PRs to be merged. Too many conflicts will appear otherwise. |
|
Ok some changes are not worth it at all. |
|
Moving code around is more likely to get me annoyed in the future so I won't do it. I had rewritten SHA-2 and SHA-3 but those as well could be dropped. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first batch of cleanup. Honestly I'm sometimes lost when I navigate through files because MD5/SHA1/SHA2 have the same naming conventions, but SHA3 and BLAKE-2 have different conventions.
I've anyway introduced too many conflicts already compared to 3.14, so I don't think it'll become better. At least, when I work towards new features or bugfixes on the main branch, I won't be lost!
I will continue updating the comments as well. For now I've just move around some code and renamed some functions/attributes/variables. I find the naming
_blake2_traverseespecially confusing as it could have been both the module or the object traverse function!@gpshead are you ok with this "purely cosmetic" change which still improves maintainability? I can isolate the clinic directive updates which are real issues (but never caught because they are never used)