gh-135244: improve wording of uuid8 docs about CSPRNG
#135433
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bedevere-app
bot
added
awaiting review
docs
LamentXU123
changed the title
LamentXU123
changed the title
|
I'll review it this evening |
picnixz
changed the title
uuid8 docs about CSPRNG
picnixz
approved these changes
Jun 13, 2025
picnixz
added
awaiting review
needs backport to 3.14
|
Thanks @LamentXU123 for the PR, and @picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 13, 2025
…GH-135433) (cherry picked from commit 394d798) Co-authored-by: LamentXU <108666168+LamentXU123@users.noreply.github.com>
|
GH-135467 is a backport of this pull request to the 3.14 branch. |
|
We don't need a 3.13 backport because UUIDv8 has only been introduced in 3.14. |
sure. Nice work. |
picnixz
pushed a commit
that referenced
this pull request
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a tiny fix of #135226
Well IMO, to avoid ambiguity, it may be changed to
caz the term "CSPRNG" stands for "cryptographically secure pseudo-random number generator" not "non-cryptographically secure pseudo-random number generator".
Could be kind of dumb caz I'm not a English native speaker lol. But I think its a little weird about the original presentation.
I've mentioned this in a deleted comment of #135244, nvm. Skipping news and issue caz this is a tiny fix in doc. Thank u for ur time @picnixz.
📚 Documentation preview 📚: https://cpython-previews--135433.org.readthedocs.build/