-
-
Notifications
You must be signed in to change notification settings - Fork 33.5k
gh-135307: Fix email error when policy max_line_length is set to 0 or None #135367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 4 commits
a210d49
e9de710
0a5f379
d0dc3c0
77ea798
52e590c
603ff74
38e6381
fa173ac
c24ec76
befa25d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| import sys | ||
| import binascii | ||
| import email.charset | ||
| import email.message | ||
|
|
@@ -142,13 +143,15 @@ def _encode_base64(data, max_line_length): | |
|
|
||
|
|
||
| def _encode_text(string, charset, cte, policy): | ||
| # max_line_length 0/None means no limit, ie: infinitely long. | ||
zangjiucheng marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| maxlen = policy.max_line_length or sys.maxsize | ||
| lines = string.encode(charset).splitlines() | ||
| linesep = policy.linesep.encode('ascii') | ||
| def embedded_body(lines): return linesep.join(lines) + linesep | ||
| def normal_body(lines): return b'\n'.join(lines) + b'\n' | ||
| if cte is None: | ||
| # Use heuristics to decide on the "best" encoding. | ||
| if max((len(x) for x in lines), default=0) <= policy.max_line_length: | ||
| if max((len(x) for x in lines), default=0) <= maxlen: | ||
|
||
| try: | ||
| return '7bit', normal_body(lines).decode('ascii') | ||
| except UnicodeDecodeError: | ||
|
|
@@ -157,7 +160,7 @@ def normal_body(lines): return b'\n'.join(lines) + b'\n' | |
| return '8bit', normal_body(lines).decode('ascii', 'surrogateescape') | ||
| sniff = embedded_body(lines[:10]) | ||
| sniff_qp = quoprimime.body_encode(sniff.decode('latin-1'), | ||
| policy.max_line_length) | ||
| maxlen) | ||
zangjiucheng marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| sniff_base64 = binascii.b2a_base64(sniff) | ||
| # This is a little unfair to qp; it includes lineseps, base64 doesn't. | ||
| if len(sniff_qp) > len(sniff_base64): | ||
|
|
@@ -172,9 +175,9 @@ def normal_body(lines): return b'\n'.join(lines) + b'\n' | |
| data = normal_body(lines).decode('ascii', 'surrogateescape') | ||
| elif cte == 'quoted-printable': | ||
| data = quoprimime.body_encode(normal_body(lines).decode('latin-1'), | ||
| policy.max_line_length) | ||
| maxlen) | ||
| elif cte == 'base64': | ||
| data = _encode_base64(embedded_body(lines), policy.max_line_length) | ||
| data = _encode_base64(embedded_body(lines), maxlen) | ||
| else: | ||
| raise ValueError("Unknown content transfer encoding {}".format(cte)) | ||
| return cte, data | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| :mod:`email`: Ensure policy accepts unlimited line lengths by | ||
| treating 0 or :const:`None` as :data:`sys.maxsize`. | ||
zangjiucheng marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
Uh oh!
There was an error while loading. Please reload this page.