Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-25068: urllib.request.ProxyHandler now lowercases the dict keys #13489

Merged
merged 1 commit into from
Sep 13, 2019
Merged

bpo-25068: urllib.request.ProxyHandler now lowercases the dict keys #13489

merged 1 commit into from
Sep 13, 2019

Conversation

ZackerySpytz
Copy link
Contributor

@ZackerySpytz ZackerySpytz commented May 22, 2019 •
edited by bedevere-bot
Loading

BoboTiG
BoboTiG approved these changes May 28, 2019
View reviewed changes
Copy link
Contributor

@BoboTiG BoboTiG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ZackerySpytz, LGTM :)

tirkarthi
tirkarthi reviewed May 28, 2019
View reviewed changes
Lib/urllib/request.py
@@ -799,6 +799,7 @@ def __init__(self, proxies=None):
assert hasattr(proxies, 'keys'), "proxies must be a mapping"
self.proxies = proxies
for type, url in proxies.items():
type = type.lower()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth adding this behavior change in https://docs.python.org/3/library/urllib.request.html#urllib.request.ProxyHandler with a versionchanged directive note?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For what it's worth, I don't think that this change needs to be documented, but it would be nice to see what a core dev thinks.

matrixise
matrixise approved these changes Sep 13, 2019
View reviewed changes
Copy link
Member

@matrixise matrixise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR

@matrixise matrixise merged commit b761e3a into python:master Sep 13, 2019
@miss-islington
Copy link
Contributor

Thanks @ZackerySpytz for the PR, and @matrixise for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-16107 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Sep 13, 2019
@miss-islington @ZackerySpytz
bpo-25068: urllib.request.ProxyHandler now lowercases the dict keys (G…
590ed09 
…H-13489)

(cherry picked from commit b761e3a)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tirkarthi tirkarthi tirkarthi left review comments

@matrixise matrixise matrixise approved these changes

@BoboTiG BoboTiG BoboTiG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ZackerySpytz @miss-islington @bedevere-bot @matrixise @BoboTiG @tirkarthi @the-knights-who-say-ni