Skip to content

gh-134830: Fix reference in Doc/extending/windows.rst #134831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

gh-134830: Fix reference in Doc/extending/windows.rst #134831

wants to merge 5 commits into from
+2 −1

Conversation

StanFromIreland
Copy link
Contributor

@StanFromIreland StanFromIreland commented May 28, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot added awaiting review docs Documentation in the Doc dir skip news labels May 28, 2025
@github-project-automation github-project-automation bot moved this to Todo in Docs PRs May 28, 2025
@StanFromIreland StanFromIreland changed the title Fix reference in Doc/extending/windows.rst gh-134830: Fix reference in Doc/extending/windows.rst May 28, 2025
@bedevere-app bedevere-app bot mentioned this pull request May 28, 2025
Open
@befeleme
Copy link
Contributor

Unfortunately this didn't help:
https://cpython-previews--134831.org.readthedocs.build/en/134831/extending/stable-abi

URL        `stable-abi'
Name       `Limited API'
Parent URL file:///builddir/build/BUILD/python3-docs-3.14.0_b2-build/Python-3.14.0b2/Doc/build/html/extending/windows.html, line 277, col 5
Real URL   file:///builddir/build/BUILD/python3-docs-3.14.0_b2-build/Python-3.14.0b2/Doc/build/html/extending/stable-abi
Check time 0.001 seconds
Result     Error: URLError: <urlopen error [Errno 2] No such file or directory: '/builddir/build/BUILD/python3-docs-3.14.0_b2-build/Python-3.14.0b2/Doc/build/html/extending/stable-abi'>

@StanFromIreland
Copy link
Contributor Author

Ah yes, I somehow did not notice that it wasn't a reference in the first place.

@befeleme
Copy link
Contributor

Perhaps the reference should be still point to the original <stable-application-binary-interface> as it refers to the whole section, rather that the sub-one?

hroncok
hroncok reviewed May 29, 2025
View reviewed changes
@StanFromIreland @hroncok
Suggestion
2619d81 
Co-authored-by: Miro Hrončok <miro@hroncok.cz>
@hroncok
Copy link
Contributor

hroncok commented May 29, 2025 •
edited
Loading

So, the problem is, the reference does not exist. It needs to be added to Doc/c-api/stable.rst

Above

cpython/Doc/c-api/stable.rst

Line 55 in e64395e

Stable Application Binary Interface

I cannot do that by suggestion.

@StanFromIreland StanFromIreland requested a review from encukou as a code owner May 29, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hroncok hroncok hroncok approved these changes

@befeleme befeleme befeleme approved these changes

@encukou encukou Awaiting requested review from encukou encukou is a code owner

Assignees
No one assigned
Labels
awaiting core review docs Documentation in the Doc dir skip news
Projects
Docs PRs
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@StanFromIreland @befeleme @hroncok