-
-
Notifications
You must be signed in to change notification settings - Fork 32k
gh-134679: Fix assertion failure in QSBR #134811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is the same underlying bug as pythongh-130519. The destructor may call arbitrary code, changing the tstate->qsbr pointer and invalidating the old _qsbr_thread_state.
Tested by running |
Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
This is the same underlying bug as pythongh-130519. The destructor may call arbitrary code, changing the `tstate->qsbr pointer` and invalidating the old `struct _qsbr_thread_state`. (cherry picked from commit a4d37f8) Co-authored-by: Sam Gross <colesbury@gmail.com>
GH-134814 is a backport of this pull request to the 3.14 branch. |
|
This is the same underlying bug as gh-130519. The destructor may call arbitrary code, changing the
tstate->qsbr
pointer and invalidating the old_qsbr_thread_state
.