Skip to content

[2.7] bpo-35121: prefix dot in domain for proper subdomain validation (GH-10258) #13426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
miss-islington merged 2 commits into from
Jun 15, 2019
Merged

[2.7] bpo-35121: prefix dot in domain for proper subdomain validation (GH-10258) #13426

miss-islington merged 2 commits into from
Jun 15, 2019

Conversation

@tirkarthi
Copy link
Member

@tirkarthi tirkarthi commented May 19, 2019 •
edited by bedevere-bot
Loading

This is a manual backport of ca7fe50 since 2.7 has http.cookiejar in cookielib

https://bugs.python.org/issue35121

@tirkarthi
Copy link
Member Author

tirkarthi commented May 19, 2019

Requesting review from @benjaminp since this is a manual backport of the security fix in 3.x branch

@tirkarthi tirkarthi closed this May 19, 2019
@tirkarthi tirkarthi reopened this May 19, 2019
@tirkarthi
Copy link
Member Author

tirkarthi commented Jun 15, 2019

@serhiy-storchaka @orsenthil @alex Would be helpful to have your review of this security backport to 2.7 branch.

@alex alex changed the title [2.7] bpo-35121: prefix dot in domain for proper subdomain validation [2.7] bpo-35121: prefix dot in domain for proper subdomain validation (GH-10258) Jun 15, 2019
@bedevere-bot bedevere-bot added the type-security A security issue label Jun 15, 2019
@miss-islington miss-islington merged commit 979daae into python:2.7 Jun 15, 2019
@tirkarthi
Copy link
Member Author

tirkarthi commented Jun 15, 2019

Thank you @alex :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alex alex alex approved these changes

Assignees

No one assigned

Labels

type-security A security issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tirkarthi @alex @the-knights-who-say-ni @bedevere-bot @miss-islington