Skip to content

gh-132983: Fix zstd compiler warning about unused function mt_continue_should_break() #133947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2025
Merged

gh-132983: Fix zstd compiler warning about unused function mt_continue_should_break() #133947

merged 1 commit into from
May 12, 2025
+2 −0

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented May 12, 2025 •
edited
Loading

Fixes the following compiler warning:

./Modules/_zstd/compressor.c:490:1: warning: unused function 'mt_continue_should_break' [-Wunused-function]
  490 | mt_continue_should_break(ZSTD_inBuffer *in, ZSTD_outBuffer *out)
      | ^~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.

@erlend-aasland erlend-aasland requested a review from emmatyping May 12, 2025 18:36
@bedevere-app bedevere-app bot mentioned this pull request May 12, 2025
Open
11 tasks
@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented May 12, 2025 •
edited
Loading

AFAICS, mt_continue_should_break is only used in an assert, so we can safely only define it if we're debugging.

@erlend-aasland erlend-aasland mentioned this pull request May 12, 2025
Open
AA-Turner
AA-Turner approved these changes May 12, 2025
View reviewed changes
Copy link
Member

@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I didn't see this compiler warning locally (do you need different flags for it?).

A

@AA-Turner AA-Turner added the needs backport to 3.14 bugs and security fixes label May 12, 2025
@AA-Turner AA-Turner merged commit 121ed71 into python:main May 12, 2025
48 checks passed
@miss-islington-app

This comment was marked as outdated.

Sign in to view
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 12, 2025
@erlend-aasland @miss-islington
pythongh-132983: Fix compiler warning about unused function ``mt_cont…
f2c2318 
…inue_should_break()`` (pythonGH-133947)

(cherry picked from commit 121ed71)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
@bedevere-app
Copy link

bedevere-app bot commented May 12, 2025

GH-133950 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label May 12, 2025
@erlend-aasland erlend-aasland deleted the zstd-warning branch May 12, 2025 19:24
AA-Turner pushed a commit that referenced this pull request May 12, 2025
@miss-islington @erlend-aasland
[3.14] gh-132983: Fix compiler warning about unused function ``mt_con…
c1aa5f8 
…tinue_should_break()`` (GH-133947) (#133950)

gh-132983: Fix compiler warning about unused function ``mt_continue_should_break()`` (GH-133947)
(cherry picked from commit 121ed71)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AA-Turner AA-Turner AA-Turner approved these changes

@emmatyping emmatyping emmatyping approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erlend-aasland @AA-Turner @emmatyping