-
-
Notifications
You must be signed in to change notification settings - Fork 32k
gh-133893: asyncio.graph: Replace TextIO annotation with io.Writer #133894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that news entry should be added here, there's no user-visible change.
Other than that - LGTM! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
…ter (pythonGH-133894) (cherry picked from commit 1d3eace) Co-authored-by: Sebastian Rittau <srittau@rittau.biz>
GH-133901 is a backport of this pull request to the 3.14 branch. |
@srittau @JelleZijlstra do know how we can type-check this file and several others in |
Type checking in the standard library has been a contentious issue, see for example https://discuss.python.org/t/type-annotations-in-the-stdlib/21487/2 I personally think that all annotated code in the standard library should be type checked, but this is probably a PEP-level problem that will cause a lot of pushback. |
There's also practical issues because type checkers assume standard library code is in typeshed. @ambv talked on the core.py podcast recently about how they achieved type checking for pyrepl with some symlink trick; but pyrepl might be a slightly easier case because it's private and not in typeshed. |
I already sneaked into It might be a reference for future work. |
Considering that this is a new module in 3.14, I think this should be backported.