bpo-24564: shutil.copystat(): ignore EINVAL on os.setxattr() #13369

yingw787 · 2019-05-16T23:38:54Z

[First-time contribution]

Carbon copy of PR #8601, except using tuples instead of sets. New pull request needed because original repo fork no longer exists.

This pull request ignores errno.EINVAL (invalid argument) when copying over extended attributes, which may cause copy to fail when copying files from a filesystem that supports extended attributes to filesystem that does not support extended attributes.

This pull request may also address bpo-36850.

CC: @giampaolo @serhiy-storchaka @abadger

https://bugs.python.org/issue24564

…n setting extended attributes using os.setxattr().

yingw787 · 2019-05-16T23:43:23Z

@abadger I am not sure how to add labels, but I believe #8601 needed a backport to 3.7 and 2.7 as they are currently accepting bugfixes (or maybe just 3.7 if 2.7 bugfix support will be dropped in 2020).

BoboTiG

Thank you @yingw787 for your first contribution :) 🍾
LTGM, even better if you would take into account my remark on the NEWs entry ;)

BoboTiG · 2019-05-18T08:02:31Z

Misc/NEWS.d/next/Library/2019-05-16-23-40-36.bpo-24564.lIwV_7.rst

@@ -0,0 +1,3 @@
+shutil.copystat(): ignore EINVAL on os.setxattr() which may occur when copying files on NFS filesystems. 


Do you mind adding markup and reword the NEWs entry? I think something like that could be good (think to use blurb to format correctly the lines):

:func:`shutil.copystat` now ignores :const:`errno.EINVAL` on :func:`os.setxattr` which may occur when copying files on filesystems without extended attributes support. Original patch by Giampaolo Rodola, updated by Ying Wang.

Sounds great, should be pushed 👍

giampaolo · 2019-05-28T06:33:08Z

Lib/shutil.py

                raise
            return
        for name in names:
            try:
                value = os.getxattr(src, name, follow_symlinks=follow_symlinks)
                os.setxattr(dst, name, value, follow_symlinks=follow_symlinks)
            except OSError as e:
-                if e.errno not in (errno.EPERM, errno.ENOTSUP, errno.ENODATA):
+                if e.errno not in (errno.EPERM,
+                    errno.ENOTSUP, errno.ENODATA, errno.EINVAL):


just a cosmetic/style nitpick - it's better to do this:

if e.errno not in (errno.EPERM, errno.ENOTSUP, errno.ENODATA, errno.EINVAL):

Should be updated!

bedevere-bot · 2019-05-28T06:33:19Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

…4564

… convention.

miss-islington · 2019-05-30T03:26:51Z

Thanks @yingw787 for the PR, and @giampaolo for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington · 2019-05-30T03:26:51Z

Thanks @yingw787 for the PR, and @giampaolo for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7.
🐍🍒⛏🤖

bedevere-bot · 2019-05-30T03:27:15Z

GH-13673 is a backport of this pull request to the 3.7 branch.

…H-13369) (cherry picked from commit a16387a) Co-authored-by: Ying Wang <me@yingw787.com>

miss-islington · 2019-05-30T03:27:17Z

Sorry, @yingw787 and @giampaolo, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker a16387ab2d85f19665920bb6ff91a7e57f59dd2a 2.7

(cherry picked from commit a16387a) Co-authored-by: Ying Wang <me@yingw787.com>

…H-13369)

BPO-24564 shutil.copystat(): ignore invalid argument error number whe…

6138e35

…n setting extended attributes using os.setxattr().

the-knights-who-say-ni added the CLA signed label May 16, 2019

bedevere-bot added the awaiting review label May 16, 2019

📜🤖 Added by blurb_it.

181e059

BoboTiG approved these changes May 18, 2019

View reviewed changes

bedevere-bot added awaiting core review and removed awaiting review labels May 18, 2019

csabella requested review from giampaolo, hynek and larryhastings May 18, 2019 11:52

BPO-24564 Update NEWS entry to use markup.p.

17ae022

giampaolo requested changes May 28, 2019

View reviewed changes

bedevere-bot added awaiting changes and removed awaiting core review labels May 28, 2019

yingw787 added 2 commits May 29, 2019 19:09

Merge branch 'master' of https://github.com/python/cpython into bpo-2…

875d07e

…4564

Update shutil.py update syntax for conditional statement according to…

5e731d2

… convention.

giampaolo merged commit a16387a into python:master May 30, 2019

bedevere-bot removed the awaiting changes label May 30, 2019

giampaolo added needs backport to 2.7 labels May 30, 2019

bedevere-bot removed the needs backport to 3.7 label May 30, 2019

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 30, 2019

bpo-24564: shutil.copystat(): ignore EINVAL on os.setxattr() (pythonG…

1edb4ec

…H-13369) (cherry picked from commit a16387a) Co-authored-by: Ying Wang <me@yingw787.com>

miss-islington assigned giampaolo May 30, 2019

giampaolo pushed a commit that referenced this pull request May 30, 2019

bpo-24564: shutil.copystat(): ignore EINVAL on os.setxattr() (GH-13369)

f1487b3

(cherry picked from commit a16387a) Co-authored-by: Ying Wang <me@yingw787.com>

DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020

bpo-24564: shutil.copystat(): ignore EINVAL on os.setxattr() (pythonG…

a9d733f

…H-13369)

chrisburr mentioned this pull request Jul 8, 2021

bpo-44205: Ignore out of space errors in shutil.copystat #26282

Open

casparvl mentioned this pull request Apr 25, 2022

Invalid cross-device link and Invalid argument errors when copying reprod directory easybuilders/easybuild-framework#3997

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

bpo-24564: shutil.copystat(): ignore EINVAL on os.setxattr() #13369

bpo-24564: shutil.copystat(): ignore EINVAL on os.setxattr() #13369

Uh oh!

yingw787 commented May 16, 2019 •

edited

Loading

Uh oh!

yingw787 commented May 16, 2019

Uh oh!

BoboTiG left a comment

Uh oh!

BoboTiG May 18, 2019

Uh oh!

yingw787 May 18, 2019

Uh oh!

giampaolo May 28, 2019

Uh oh!

yingw787 May 29, 2019

Uh oh!

bedevere-bot commented May 28, 2019

Uh oh!

miss-islington commented May 30, 2019

Uh oh!

miss-islington commented May 30, 2019

Uh oh!

bedevere-bot commented May 30, 2019

Uh oh!

miss-islington commented May 30, 2019

Uh oh!

Uh oh!

		@@ -0,0 +1,3 @@
		shutil.copystat(): ignore EINVAL on os.setxattr() which may occur when copying files on NFS filesystems.

Uh oh!

bpo-24564: shutil.copystat(): ignore EINVAL on os.setxattr() #13369

bpo-24564: shutil.copystat(): ignore EINVAL on os.setxattr() #13369

Uh oh!

Conversation

yingw787 commented May 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yingw787 commented May 16, 2019

Uh oh!

BoboTiG left a comment

Choose a reason for hiding this comment

Uh oh!

BoboTiG May 18, 2019

Choose a reason for hiding this comment

Uh oh!

yingw787 May 18, 2019

Choose a reason for hiding this comment

Uh oh!

giampaolo May 28, 2019

Choose a reason for hiding this comment

Uh oh!

yingw787 May 29, 2019

Choose a reason for hiding this comment

Uh oh!

bedevere-bot commented May 28, 2019

Uh oh!

miss-islington commented May 30, 2019

Uh oh!

miss-islington commented May 30, 2019

Uh oh!

bedevere-bot commented May 30, 2019

Uh oh!

miss-islington commented May 30, 2019

Uh oh!

Uh oh!

yingw787 commented May 16, 2019 •

edited

Loading