-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
gh-133581: Improve AST unparsing of t-strings #133635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @JelleZijlstra! Let's backport this to 3.14 as well.
Thanks @JelleZijlstra for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
(cherry picked from commit bfac7d2) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
GH-133666 is a backport of this pull request to the 3.14 branch. |
Looks like some refleak buildbots started failing after this. https://buildbot.python.org/#/builders/1735/builds/6
|
Yup, it bisects to this commit on the 3.14 branch:
|
Thanks for flagging, I'll investigate. Must be one of the changes in |
Fix in #133724. The issue was in the existing code, it just wasn't tested before. |
Fix unparsing of empty t-strings, and use the string value in unparsing interpolations.