Skip to content

gh-133623: Add ssl.HAS_PSK_TLS13 to detect external TLS 1.3 PSK support #133624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 9, 2025

Conversation

WillChilds-Klein
Copy link
Contributor

@WillChilds-Klein WillChilds-Klein commented May 7, 2025

Notes

Please see #133623's description for broader discussion of the feature.

AWS-LC now sets an OPENSSL_NO_EXTERNAL_PSK_TLS13 macro that this PR uses to detect external TLS 1.3 PSK support.

This PR is largely based on PR #128036's patterns. If the edit to Doc/whatsnew/3.15.rst is unnecessary, I'm happy to remove it.

Testing

  • CPython CI
  • AWS-LC recently adjusted our CPython CI patch file, conforming to this PR's contents


📚 Documentation preview 📚: https://cpython-previews--133624.org.readthedocs.build/

WillChilds-Klein and others added 2 commits May 7, 2025 19:00
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@picnixz picnixz self-assigned this May 7, 2025
@picnixz picnixz merged commit 6801bd3 into python:main May 9, 2025
39 checks passed
@WillChilds-Klein WillChilds-Klein deleted the has-psk-tls13 branch May 9, 2025 14:13
WillChilds-Klein added a commit to aws/aws-lc that referenced this pull request May 9, 2025
As of [PR 133624](python/cpython#133624),
CPython's mainline is now fully source- and test-compatible with AWS-LC.
This means that we can reduce our CI patch file to a static build
configuration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants