[3.13] gh-109981: Resolve situation on iOS regarding fd_count. (GH-132823) #132824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…GH-132823) Modifies the test helper that counts the list of open file descriptors to use the optimised ``/dev/fd`` approach on all Apple platforms, not just macOS. This avoids crashes caused by guarded file descriptors. (cherry picked from commit 862fd89) Co-authored-by: John <johnzhou721@gmail.com>
|
All commit authors signed the Contributor License Agreement. |
This was referenced Apr 23, 2025
freakboy3742
approved these changes
Apr 23, 2025
|
@johnzhou721 I'm not sure why the CLA bot is rejecting this one; is it possible you didn't sign the CLA with the email address attached to the PR ( |
I've confirmed with the bot maintainers - the issue is that your git client and GitHub accounts are associated with different email addresses; you'll need to follow the link above and sign the CLA a second time. That should allow you to sign with the account tied to your Github account; let us know if you have any problems. |
|
To people waiting to merge this: I don't have access to GitHub right now
(on a school computer, replying through email) and will sign the CLA after
I get home around 4:30pm central time.
…On Tue, Apr 22, 2025 at 11:16 PM Russell Keith-Magee < ***@***.***> wrote:
@johnzhou721 <https://github.com/johnzhou721> I'm not sure why the CLA
bot is rejecting this one; is it possible you didn't sign the CLA with the
email address attached to the PR ***@***.***)?
I've confirmed with the bot maintainers - the issue is that your git
client and GitHub accounts are associated with different email addresses;
you'll need to follow the link above and sign the CLA a second time. That
*should* allow you to sign with the account tied to your Github account;
let us know if you have any problems.
—
Reply to this email directly, view it on GitHub
<#132824 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BRODAI3AVO2OQBKK4NC4OSD224HYXAVCNFSM6AAAAAB3VGHXVCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMRTGAYTCMJUGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
*freakboy3742* left a comment (python/cpython#132824)
<#132824 (comment)>
@johnzhou721 <https://github.com/johnzhou721> I'm not sure why the CLA
bot is rejecting this one; is it possible you didn't sign the CLA with the
email address attached to the PR ***@***.***)?
I've confirmed with the bot maintainers - the issue is that your git
client and GitHub accounts are associated with different email addresses;
you'll need to follow the link above and sign the CLA a second time. That
*should* allow you to sign with the account tied to your Github account;
let us know if you have any problems.
—
Reply to this email directly, view it on GitHub
<#132824 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BRODAI3AVO2OQBKK4NC4OSD224HYXAVCNFSM6AAAAAB3VGHXVCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMRTGAYTCMJUGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies the test helper that counts the list of open file descriptors to use
the optimised
/dev/fdapproach on all Apple platforms, not just macOS. Thisavoids crashes caused by guarded file descriptors.
(cherry picked from commit 862fd89)
Co-authored-by: John johnzhou721@gmail.com