GH-131296: fix clang-cl parentheses warnings on Windows #131905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-eibl
commented
Mar 30, 2025
| @@ -6111,7 +6111,7 @@ _ssl_enum_certificates_impl(PyObject *module, const char *store_name) | |||
| return PyErr_SetFromWindowsErr(GetLastError()); | |||
| } | |||
|
|
|||
| while (pCertCtx = CertEnumCertificatesInStore(hCollectionStore, pCertCtx)) { | |||
| while ((pCertCtx = CertEnumCertificatesInStore(hCollectionStore, pCertCtx))) { | |||
There was a problem hiding this comment.
Fix warning : using the result of an assignment as a condition without parentheses [-Wparentheses].
chris-eibl
commented
Mar 30, 2025
| @@ -6210,7 +6210,7 @@ _ssl_enum_crls_impl(PyObject *module, const char *store_name) | |||
| return PyErr_SetFromWindowsErr(GetLastError()); | |||
| } | |||
|
|
|||
| while (pCrlCtx = CertEnumCRLsInStore(hCollectionStore, pCrlCtx)) { | |||
| while ((pCrlCtx = CertEnumCRLsInStore(hCollectionStore, pCrlCtx))) { | |||
There was a problem hiding this comment.
Fix warning : using the result of an assignment as a condition without parentheses [-Wparentheses].
chris-eibl
commented
Mar 30, 2025
| @@ -5372,7 +5372,7 @@ _testFileExistsByName(LPCWSTR path, BOOL followLinks) | |||
| sizeof(info))) | |||
| { | |||
| if (!(info.FileAttributes & FILE_ATTRIBUTE_REPARSE_POINT) || | |||
| !followLinks && IsReparseTagNameSurrogate(info.ReparseTag)) | |||
| (!followLinks && IsReparseTagNameSurrogate(info.ReparseTag))) | |||
There was a problem hiding this comment.
Fix warning : '&&' within '||' [-Wlogical-op-parentheses].
chris-eibl
commented
Mar 30, 2025
| @@ -2760,7 +2760,7 @@ process(int argc, wchar_t ** argv) | |||
| // We searched earlier, so if we didn't find anything, now we react | |||
| exitCode = searchExitCode; | |||
| // If none found, and if permitted, install it | |||
| if (exitCode == RC_NO_PYTHON && isEnvVarSet(L"PYLAUNCHER_ALLOW_INSTALL") || | |||
| if (((exitCode == RC_NO_PYTHON) && isEnvVarSet(L"PYLAUNCHER_ALLOW_INSTALL")) || | |||
There was a problem hiding this comment.
Fix warning : '&&' within '||' [-Wlogical-op-parentheses].
chris-eibl
changed the title
|
Eh, personally I think these make the code uglier, but there are so few changes that we may as well. Consistency between platforms is worth it. |
seehwan
pushed a commit
to seehwan/cpython
that referenced
this pull request
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is a skip news?
This might seem unneeded, but in the Linux code base, the same warning levels are active, but do not fire.
IMHO, it is better to have these warnings active in the Windows code base, too, and fix them.
Every mainstream compiler warns on this suspicious-looking code.