gh-127146: Fix Emscripten build with --pydebug#131672
Merged
freakboy3742 merged 1 commit intopython:mainfrom Mar 24, 2025
Merged
gh-127146: Fix Emscripten build with --pydebug#131672freakboy3742 merged 1 commit intopython:mainfrom
freakboy3742 merged 1 commit intopython:mainfrom
Conversation
The deleted logic checks that the sysconfigdata is in a short list, and the list does not allow the `d` ABI flag to be present. I removed the check because I don't think it is helpful.
freakboy3742
approved these changes
Mar 24, 2025
Contributor
freakboy3742
left a comment
freakboy3742
left a comment
There was a problem hiding this comment.
👍 Seems reasonable. If the build is generating the wrong sysconfigdata name, other things are going to explode; and with the new error reporting, that's going to be a lot easier to diagnose.
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 1, 2025
Removes an explicit check that sysconfigdata naming is correct, in favor of reporting at runtime with the default mechanisms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deleted logic checks that the sysconfigdata is in a short list, and the list does not allow the
dABI flag to be present so it fails if we build with--with-pydebug. I removed the check because I don't think it is helpful.