GH-131296: fix clang-cl warning on Windows in overlapped.c#131590
Merged
zooba merged 1 commit intopython:mainfrom Apr 16, 2025
Merged
GH-131296: fix clang-cl warning on Windows in overlapped.c#131590zooba merged 1 commit intopython:mainfrom
zooba merged 1 commit intopython:mainfrom
Conversation
chris-eibl
commented
Mar 22, 2025
| @@ -1811,13 +1811,6 @@ _overlapped_Overlapped_WSASendTo_impl(OverlappedObject *self, HANDLE handle, | |||
| } | |||
| } | |||
|
|
|||
Member
Author
There was a problem hiding this comment.
Fix warning : unused variable 'Overlapped_WSARecvFrom_doc' [-Wunused-const-variable].
Must be a left-over (and the only PyDoc_STRVAR in overlapped.c).
The currently used PyDoc_STRVAR is here:
cpython/Modules/clinic/overlapped.c.h
Lines 1145 to 1149 in 18249d9
Member
Author
|
@zooba I think this is a simple (and only Windows related) one? |
|
Contributor
|
The iOS failure is caused by #127108. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this is a skip news?