GH-131296: fix clang-cl warnings on Windows in blake2module.c #131299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpshead
approved these changes
Mar 15, 2025
| @@ -92,10 +92,10 @@ void detect_cpu_features(cpu_flags *flags) { | |||
| ebx7 = info7[1]; | |||
| ecx7 = info7[2]; | |||
| edx7 = info7[3]; | |||
| #else | |||
| #endif | |||
| (void) eax1; (void) ebx1; (void) ecx1; (void) edx1; | |||
There was a problem hiding this comment.
LOL... definitely fighting against the compiler's idea of best practices here using useless no-op statements as a way to work around it. i wish we could disable a specific warning for a whole block of code. i feel like a future compiler will notice that these are useless and stop considering them a "use".
There was a problem hiding this comment.
It was just the least minimal change to silence the warning :)
Luckily, I think we'll never have to fear that this will ever need a change: that (void) pattern is adapted by all known compilers for ages - and I think this will stay.
picnixz
approved these changes
Mar 15, 2025
| (void) eax1; (void) ebx1; (void) ecx1; (void) edx1; | ||
| (void) eax7; (void) ebx7; (void) ecx7; (void) edx7; | ||
| #endif | ||
|
|
There was a problem hiding this comment.
Can you remove the double blank lines L98/L99 please? TiA
|
Oh it was merged :') |
plashchynski
pushed a commit
to plashchynski/cpython
that referenced
this pull request
Mar 17, 2025
…ython#131299) work around unimportant clang-cl warnings in blake2module.c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
we see them two (non-PGO) or three times, because the
_freeze_modulecompiles blake2module.c, too.I think this is a skip news.