gh-131234: Improve test_popen with more asserts
#131235
Merged
+9
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
added
tests
picnixz
reviewed
Mar 14, 2025
|
Done! |
picnixz
approved these changes
Mar 14, 2025
|
Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 14, 2025
) (cherry picked from commit fc07f86) Co-authored-by: sobolevn <mail@sobolevn.me>
|
GH-131240 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 14, 2025
) (cherry picked from commit fc07f86) Co-authored-by: sobolevn <mail@sobolevn.me>
|
GH-131241 is a backport of this pull request to the 3.12 branch. |
sobolevn
added a commit
that referenced
this pull request
Mar 14, 2025
sobolevn
added a commit
that referenced
this pull request
Mar 14, 2025
mikec9
pushed a commit
to mikec9/cpython
that referenced
this pull request
Mar 14, 2025
…nGH-131235) (python#131241) pythongh-131234: Improve `test_popen` with more asserts (pythonGH-131235) (cherry picked from commit fc07f86) Co-authored-by: sobolevn <mail@sobolevn.me>
plashchynski
pushed a commit
to plashchynski/cpython
that referenced
this pull request
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_keywordsintest_popencan be improved #131234