Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove print from test_monitoring.py #131200

Merged
merged 1 commit into from
Mar 13, 2025

Conversation

sobolevn
Copy link
Member

Before:

» ./python.exe -m test test_monitoring
Using random seed: 921836869
0:00:00 load avg: 1.52 Run 1 test sequentially in a single process
0:00:00 load avg: 1.52 [1/1] test_monitoring
[('branch left', 'foo', 10, 16), ('branch left', 'foo', 10, 16), ('branch left', 'foo', 10, 16), ('branch left', 'foo', 10, 16), ('branch right', 'foo', 10, 40)]
[('branch left', 'foo', 36, 40), ('branch left', 'foo', 36, 40), ('branch right', 'foo', 36, 52)]
[('branch left', 'func', 40, 46), ('branch left', 'func', 124, 130)]
[('branch left', 'func', 28, 32), ('branch right', 'func', 44, 58), ('branch left', 'func', 28, 32), ('branch left', 'func', 44, 50), ('branch right', 'func', 28, 70)]
[('branch left', 'whilefunc', 10, 16), ('branch left', 'whilefunc', 10, 16), ('branch left', 'whilefunc', 10, 16), ('branch right', 'whilefunc', 10, 38)]
0:00:00 load avg: 1.52 [1/1] test_monitoring passed

== Tests result: SUCCESS ==

1 test OK.

Total duration: 101 ms
Total tests: run=86
Total test files: run=1/1
Result: SUCCESS
                 

After:

» ./python.exe -m test test_monitoring                     
Using random seed: 1417341001
0:00:00 load avg: 1.71 Run 1 test sequentially in a single process
0:00:00 load avg: 1.71 [1/1] test_monitoring
0:00:00 load avg: 1.71 [1/1] test_monitoring passed

== Tests result: SUCCESS ==

1 test OK.

Total duration: 102 ms
Total tests: run=86
Total test files: run=1/1
Result: SUCCESS
                 

Looks like it was left here after a debugging of #130847

I am pretty sure that it should not print anything by default. In case you want to have that, I can add if support.verbose check there.

@sobolevn sobolevn merged commit 1a8e574 into python:main Mar 13, 2025
50 checks passed
plashchynski pushed a commit to plashchynski/cpython that referenced this pull request Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip issue skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants