GH-127705: Handle trace refs in specialized decref#131198
GH-127705: Handle trace refs in specialized decref#131198encukou merged 1 commit intopython:mainfrom
Conversation
|
!buildbot TraceRef |
|
🤖 New build scheduled with the buildbot fleet by @markshannon for commit b5eb234 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F131198%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
colesbury
left a comment
colesbury
left a comment
There was a problem hiding this comment.
I don't think we should be exposing Py_DECREF_MORTAL and Py_DECREF_MORTAL_SPECIALIZED to extensions when they include Python.h. It seems to me like they belong in pycore_object.h or some other internal-only header.
| #ifdef Py_TRACE_REFS | ||
| _Py_ForgetReference(op); | ||
| #endif | ||
| destruct(op); |
There was a problem hiding this comment.
This is missing a _PyReftracerTrack(op, PyRefTracer_DESTROY);
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
I agree, but it is infeasible now due to cyclic includes. |
|
Merging as is, so we don't release with |
|
Can you please rename Py_DECREF_MORTAL_SPECIALIZED() to _Py_DECREF_MORTAL_SPECIALIZED() in the public C API? |
…1198) This is missing `_PyReftracerTrack` calls, see pythongh-131238. Merging as-is for the 3.14.0a6 release.
7 participants
Adds a couple of
_Py_ForgetReferences that were overlooked.