Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-93096: Move random benchmark into pyperformance #131144

Closed
wants to merge 2 commits into from

Conversation

donBarbos
Copy link
Contributor

@donBarbos donBarbos commented Mar 12, 2025

@donBarbos
Copy link
Contributor Author

cc @vstinner
:-)

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

cc @hugovk

@rhettinger
Copy link
Contributor

This isn't a performance test. It is used by module maintainers to view generated distributions to see if they match the expected distributions.

@rhettinger rhettinger requested a review from tim-one March 12, 2025 17:21
@donBarbos
Copy link
Contributor Author

I think it would be right to get rid of the --test flags in modules with cli.
This flag is not documented and is not displayed in the --help output.

And it seems author of this flag is not against removing it

@rhettinger
Copy link
Contributor

I'm going to decline this. It isn't part of the public API so there is no user benefit to removing it. I do use this when maintaining the module so it does have some value. And the test code has nothing to do with pyperformance so this PR would be moving the code from where a mainainer can find it to a place where it clearly doesn't make sense.

@rhettinger rhettinger closed this Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants