Skip to content

gh-130824: Clean up test wrappers for PyLong_*AndOverflow functions #130871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 5, 2025
Merged

gh-130824: Clean up test wrappers for PyLong_*AndOverflow functions #130871

merged 1 commit into from
Mar 5, 2025

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Mar 5, 2025 •
edited by bedevere-app bot
Loading

@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir skip news needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Mar 5, 2025
@bedevere-app bedevere-app bot mentioned this pull request Mar 5, 2025
Closed
@serhiy-storchaka serhiy-storchaka mentioned this pull request Mar 5, 2025
Merged
@encukou
Copy link
Member

encukou commented Mar 5, 2025

Thank you, and sorry for the premature merge

@encukou encukou merged commit 63d25f8 into python:main Mar 5, 2025
51 checks passed
@miss-islington-app
Copy link

Thanks @serhiy-storchaka for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @serhiy-storchaka and @encukou, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 63d25f8d0c4f4626fb9f1131402d95fdaca34a57 3.13

@miss-islington-app
Copy link

Sorry, @serhiy-storchaka and @encukou, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 63d25f8d0c4f4626fb9f1131402d95fdaca34a57 3.12

ZeroIntensity
ZeroIntensity approved these changes Mar 5, 2025
View reviewed changes
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZeroIntensity
Copy link
Member

Oops, the merge happened right as I reviewed it 😅

encukou pushed a commit to miss-islington/cpython that referenced this pull request Mar 5, 2025
@serhiy-storchaka @encukou
pythongh-130824: Clean up test wrappers for PyLong_*AndOverflow funct…
a4861bf 
…ions (pythonGH-130871)
@picnixz
Copy link
Member

picnixz commented Apr 5, 2025

Backports failed here @serhiy-storchaka Do you want to address them?

@serhiy-storchaka serhiy-storchaka removed needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Apr 5, 2025
@serhiy-storchaka
Copy link
Member Author

serhiy-storchaka commented Apr 5, 2025 •
edited
Loading

These changes were included in the backports of the original PR #130828.

@serhiy-storchaka serhiy-storchaka deleted the test-pylong_aslongandoverflow branch April 5, 2025 12:29
seehwan pushed a commit to seehwan/cpython that referenced this pull request Apr 16, 2025
@serhiy-storchaka @seehwan80
pythongh-130824: Clean up test wrappers for PyLong_*AndOverflow funct…
0c0cdcd 
…ions (pythonGH-130871)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

@encukou encukou Awaiting requested review from encukou

Assignees

@encukou encukou

Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@serhiy-storchaka @encukou @ZeroIntensity @picnixz