Fix a typo in code module test#130530
Merged
gaogaotiantian merged 1 commit intopython:mainfrom Feb 25, 2025
Merged
Conversation
terryjreedy
approved these changes
Feb 25, 2025
Member
terryjreedy
left a comment
terryjreedy
left a comment
There was a problem hiding this comment.
I had forgotten about writing fix 5a4bbcd. I obviously fixed test_ps2 with a copy-paste from test_ps1 that had incomplete modification of '1' to '2'. The two errors cancel but should be fixed.
serhiy-storchaka
added
needs backport to 3.12
|
Thanks @gaogaotiantian for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
|
Thanks @gaogaotiantian for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 25, 2025
(cherry picked from commit 56e337d) Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 25, 2025
(cherry picked from commit 56e337d) Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>
|
GH-130533 is a backport of this pull request to the 3.12 branch. |
|
GH-130534 is a backport of this pull request to the 3.13 branch. |
serhiy-storchaka
pushed a commit
that referenced
this pull request
Feb 25, 2025
gaogaotiantian
added a commit
that referenced
this pull request
Feb 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm 99% sure this is not intended in 5a4bbcd.