gh-129915: Add __qualname__ to class namespace when constructing slotted dataclass
#129916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thejcannon
changed the title
__qualname__ to class namespace when constructing slotted dataclass__qualname__ to class namespace when constructing slotted dataclass
sobolevn
reviewed
Feb 9, 2025
Co-authored-by: sobolevn <mail@sobolevn.me>
sobolevn
reviewed
Feb 10, 2025
| class D(C): | ||
| pass | ||
|
|
||
| self.assertEqual(D.__qualname__, 'TestSlots.test_slots_qualname.<locals>.D') |
There was a problem hiding this comment.
Can you please run your tests as -m test test_dataclasses and as python.exe Lib/test/test_dataclasses/__init__.py directly? qualname might be changed
There was a problem hiding this comment.
Hmm I'm not following how running it directly would produce a different result than the passing CI check? What am I missing?
There was a problem hiding this comment.
I assume @sobolevn thinks the imported class name might change.
There was a problem hiding this comment.
Yeah, I am not sure it will, just double checking.
|
The following commit authors need to sign the Contributor License Agreement: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #129915 by shifting the "set the
__qualname__" responsibility to be a property of the__qualname__being inside the class namespace.(For the record, oof the bug was really painful to run into 😅 )
__qualname__in slotted dataclasses in__init_subclass__#129915