gh-127146: Skip test_readinto_non_blocking on Emscripten#129421
gh-127146: Skip test_readinto_non_blocking on Emscripten#129421freakboy3742 merged 1 commit intopython:mainfrom
Conversation
non_blocking doesn't really work on Emscripten
|
@hoodmane, @freakboy3742 rather than a platform-specific check for this one test, could you make it so the |
|
@cmaloney That's definitely an approach that we could take - it's an approach that iOS and Android use for a bunch of APIs in the "they exist, but you can't call them" category. However, in this case, it's not 100% clear if the issue here is a bug in Emscripten itself. If it is, then a test skip seems more appropriate. If it turns out there is a fundamental limitation that prevents Emscripten from avoiding the problem causing this test failure, then I'd agree guarding the entire feature would make sense. |
non_blocking doesn't really work on Emscripten.