Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-91417: Remove PySequence_Fast() from the limited C API #129398

Merged
merged 1 commit into from
Feb 2, 2025

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Jan 28, 2025

The function never worked with the limited C API. It was added by mistake.


📚 Documentation preview 📚: https://cpython-previews--129398.org.readthedocs.build/

The function never worked with the limited C API. It was added by
mistake.
@vstinner
Copy link
Member Author

cc @serhiy-storchaka

@vstinner
Copy link
Member Author

cc @encukou

Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but this should be discussed within the C API Workgroup.

@vstinner
Copy link
Member Author

this should be discussed within the C API Workgroup.

Ok, I created capi-workgroup/decisions#55 discussion.

@vstinner vstinner merged commit 2ad069d into python:main Feb 2, 2025
48 checks passed
@vstinner vstinner deleted the remove_sequence_fast branch February 2, 2025 22:17
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Feb 7, 2025
…on#129398)

The function never worked with the limited C API. It was added by
mistake.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants